Skip to content

Improve support for connections without auth (Final PR for 1.14.0) #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anderson4j merged 3 commits into from
Jan 8, 2026
Merged

Improve support for connections without auth (Final PR for 1.14.0) #629

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebf3642
removes validation of user/password so one can connect to db without …
anderson4j Jan 7, 2026
a89b7fd
Merge branch 'main' of https://github.com/neo4j/cypher-language-suppo…
anderson4j Jan 8, 2026
bae301d
add change to changelog
anderson4j Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions packages/vscode-extension/src/webviews/controllers/connectionPanelController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,41 +13,28 @@ declare const vscode: vscode;

/**
* Validates a Connection object and a password from the webview form.ƒ
* @param connection The Connection object to validate. Only scheme, host, user, and password are required.
* @param connection The Connection object to validate. Only scheme and host are required.
* @param password The password to validate.
* @returns True if the connection is valid, false otherwise.
*/
export function validateConnection(
connection: Connection | null,
password: string,
): boolean {
export function validateConnection(connection: Connection | null): boolean {
highlightInvalidFields();
return (
!connection ||
(!!connection.scheme &&
!!connection.host &&
!!connection.user &&
!!password)
);
return !connection || (!!connection.scheme && !!connection.host);
}

/**
* Highlights any invalid fields in the webview form by toggling the invalid class.
* Only scheme, host, user, and password are required.
* Only scheme and host are required.
*/
export function highlightInvalidFields(): void {
const scheme = document.getElementById('scheme') as HTMLInputElement;
const host = document.getElementById('host') as HTMLInputElement;
const user = document.getElementById('user') as HTMLInputElement;
const password = document.getElementById('password') as HTMLInputElement;

scheme.classList.toggle(
'invalid',
!scheme.value || !isValidScheme(scheme.value),
);
host.classList.toggle('invalid', !host.value);
user.classList.toggle('invalid', !user.value);
password.classList.toggle('invalid', !password.value);
}

/**
Expand Down Expand Up @@ -123,7 +110,7 @@ export function onSubmit(event: Event): boolean {
const connection = getConnection();
const password = getPassword();

if (!validateConnection(connection, password)) {
if (!validateConnection(connection)) {
vscode.postMessage({
command: 'onValidationError',
});
Expand Down