Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 42N3A, 42N3B, 42N3C and updated 42N39 #252

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Added 42N3A, 42N3B, 42N3C and updated 42N39 #252

wants to merge 2 commits into from

Conversation

JoelBergstrand
Copy link
Contributor

Adding documentation for error codes added in Top Level Braces and Conditional Subqueries.

@JoelBergstrand JoelBergstrand added dev The default branch. Cypher 25 labels Jan 17, 2025
@neo-technology-commit-status-publisher
Copy link
Collaborator

This PR includes documentation updates
View the updated docs at https://neo4j-docs-status-codes-252.surge.sh

Updated pages:

JPryce-Aklundh
JPryce-Aklundh reviewed Feb 4, 2025
View reviewed changes
Copy link

@JPryce-Aklundh JPryce-Aklundh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments from me @JoelBergstrand.
Could you also take a look @renetapopova?

modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
@renetapopova renetapopova self-assigned this Feb 4, 2025
@renetapopova
Copy link
Collaborator

A few comments from me @JoelBergstrand. Could you also take a look @renetapopova?

Sure. I have an upcoming PR that changes the structure of the error codes, I can take this PR from here and update it accordingly.

I like your suggestions, @JPryce-Aklundh.

@JoelBergstrand
Copy link
Contributor Author

Sorry, I didn't see your comments until now. The suggestions look great. @renetapopova are you take ownership of the PR with the new structure?

@JoelBergstrand @JPryce-Aklundh
Apply suggestions from code review
094bc48 
Co-authored-by: Jens Pryce-Åklundh <[email protected]>
@renetapopova
Copy link
Collaborator

Sorry, I didn't see your comments until now. The suggestions look great. @renetapopova are you take ownership of the PR with the new structure?

Yes, I'll take care of it. Thanks @JoelBergstrand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPryce-Aklundh JPryce-Aklundh JPryce-Aklundh left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@renetapopova renetapopova

Labels
Cypher 25 dev The default branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoelBergstrand @neo-technology-commit-status-publisher @renetapopova @JPryce-Aklundh