Support for non node types on cypher directives #6199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 944c8f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
angrykoala
force-pushed
the
support-custom-cypher-types
branch
from
944c8f6 to
739025c
Compare
Comment on lines
+209
to
+211
| /** | ||
| * Interfaces without `@node` are not supported yet because there is no way to access "__resolveTree", as the information of the concrete type returned by the cypher field is not available | ||
| */ |
There was a problem hiding this comment.
What will happen in this case? Will we throw a validation error? Or just some weird indecipherable error?
| const Movie = testHelper.createUniqueType("Movie"); | ||
|
|
||
| const typeDefs = /* GraphQL */ ` | ||
| type Movie @node { |
There was a problem hiding this comment.
@node shouldn't he here right?
Suggested change
| type Movie @node { | |
| type Movie { |
Comment on lines
+44
to
+48
| type ${Link} { | ||
| movieId: String! | ||
| url: String! | ||
| name: String! | ||
| } |
There was a problem hiding this comment.
How about this kind of case where the Cypher might return a more complex object?
Suggested change
| type ${Link} { | |
| movieId: String! | |
| url: String! | |
| name: String! | |
| } | |
| type ${Link} { | |
| movieId: String! | |
| url: String! | |
| name: String! | |
| somethingElse: SomethingElse! | |
| } | |
| type ${SomethingElse} { | |
| something: String! | |
| } |
Comment on lines
-144
to
-146
| if (attributeType instanceof InterfaceEntity || attributeType instanceof UnionEntity) { | ||
| throw new Error("@cypher field target cannot be an interface or an union"); | ||
| } |
There was a problem hiding this comment.
Maybe we should be keeping this given the skipped test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for
@cypherdirective of fields targeting types that do not use the@nodedirective. For example:This approach has some limitations, particularly with non-node interfaces and unions