Migrate upload-artifact action to v4 and update cypress dependent packages #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarDamkjaer
approved these changes
Feb 4, 2025
daveajrussell
commented
Feb 4, 2025
| @@ -39,13 +39,13 @@ jobs: | |||
| - run: yarn install --frozen-lockfile | |||
| - run: yarn build | |||
| - run: sudo apt-get update | |||
| - run: sudo apt-get -y install libgtk2.0-0 libgtk-3-0 libgbm-dev libnotify-dev libgconf-2-4 libnss3 libxss1 libasound2 libxtst6 xauth xvfb | |||
| - run: sudo apt-get -y install libgtk2.0-0t64 libgtk-3-0t64 libgbm-dev libnotify-dev libnss3 libxss1 libasound2t64 libxtst6 xauth xvfb | |||
There was a problem hiding this comment.
see https://docs.cypress.io/app/get-started/install-cypress#UbuntuDebian
ubuntu-latest resolves to 24.04 https://github.com/actions/runner-images?tab=readme-ov-file#available-images
daveajrussell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V3 of the upload/download artifact actions have been deprecated, and removed since January 25th https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
This PR migrates to v4.
It doesn't seem necessary to make any additional changes outlined in the migration guide https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md here, since it doesn't look like we were previously mutating uploaded artifacts from different runs.
We are also updating some packages that cypress is dependent on in the image, see https://docs.cypress.io/app/get-started/install-cypress#UbuntuDebian
ubuntu-latest resolves to 24.04 https://github.com/actions/runner-images?tab=readme-ov-file#available-images