Replace pygraphviz with neo4j-viz for graph visualization #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellasia
reviewed
Mar 20, 2025
oskarhane
force-pushed
the
feature/replace-pygraphviz-with-neo4j-viz
branch
from
1cb21f1 to
0a14de3
Compare
This commit replaces pygraphviz with neo4j-viz for pipeline visualization, providing a more interactive HTML-based visualization experience. The changes include: - Updated the Pipeline.draw() method to generate HTML output using neo4j-viz - Added a new get_neo4j_viz_graph() method while maintaining backward compatibility - Updated dependencies in pyproject.toml to use neo4j-viz instead of pygraphviz - Updated documentation and examples to reflect the change from PNG to HTML output - Updated unit tests to work with the new visualization implementation - Added stub file for neo4j-viz to make mypy happy
oskarhane
force-pushed
the
feature/replace-pygraphviz-with-neo4j-viz
branch
from
2916e37 to
54fe2eb
Compare
willtai
reviewed
Apr 7, 2025
stellasia
reviewed
Apr 14, 2025
| relationships.append(rel) | ||
|
|
||
| # Cast the constructor to Any, then cast the result back to VisualizationGraph | ||
| viz_graph = cast(Any, VisualizationGraph)( |
There was a problem hiding this comment.
What's the mypy error without this cast?
There was a problem hiding this comment.
Also, isn't the pyi file supposed to help mypy here? Otherwise why do we have this file?
|
Just realized we can remove pygraphviz install from the GH actions ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neo4j has its own viz library, let's use that!
Type of Change
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):