Skip to content

Removes | char from type hints to be compatible with Python 3.9 #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2025

Conversation

alexthomas93
Copy link
Contributor

Description

Removes | char from type hints to be compatible with Python 3.9

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update
  • Project configuration change

Complexity

Low

How Has This Been Tested?

  • Unit tests
  • E2E tests
  • Manual tests

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • Unit tests have been updated
  • E2E tests have been updated
  • Examples have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed
  • CHANGELOG.md updated if appropriate

@alexthomas93 alexthomas93 requested a review from a team as a code owner July 17, 2025 13:41
Copy link
Contributor

@NathalieCharbel NathalieCharbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

one minor comment, not worth blocking this PR though: would Optional[...] be better than Union[..., None] for readability?

@alexthomas93
Copy link
Contributor Author

LGTM :)

one minor comment, not worth blocking this PR though: would Optional[...] be better than Union[..., None] for readability?

Good point! I've updated it here and here

@alexthomas93 alexthomas93 merged commit 9f69084 into neo4j:main Jul 17, 2025
8 checks passed
@alexthomas93 alexthomas93 deleted the bugfix/3.9-typing branch July 17, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants