Skip to content

Conversation

@kjvalencik
Copy link
Member

No description provided.

@kjvalencik kjvalencik changed the title Initial async/await RFC Futures RFC Mar 9, 2022
kjvalencik added a commit to neon-bindings/neon that referenced this pull request Mar 9, 2022
@kjvalencik
Copy link
Member Author

I propose that we only implement this for Node-API >= 5, allowing the usage of JsFunction::new from closures. This simplifies the state management.

If we would like to support this for lower versions, we will need to find an alternate way to track the state. For example, putting it in a JsBox and calling Function.prototype.bind on our .then and .catch methods.

kjvalencik added a commit to neon-bindings/neon that referenced this pull request Jun 3, 2022
kjvalencik added a commit to neon-bindings/neon that referenced this pull request Jun 3, 2022
kjvalencik added a commit to neon-bindings/neon that referenced this pull request Jun 3, 2022
kjvalencik added a commit to neon-bindings/neon that referenced this pull request Jun 9, 2022
kjvalencik added a commit to neon-bindings/neon that referenced this pull request Jun 9, 2022
kjvalencik added a commit to neon-bindings/neon that referenced this pull request Jun 9, 2022
kjvalencik added a commit to neon-bindings/neon that referenced this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants