Skip to content

Commit 99639c2

Browse files
jcgruenhagejcgruenhage
authoredMar 18, 2025··
fix(ci): update build-tools image references (#11293)
## Problem #11210 migrated pushing images to ghcr. Unfortunately, it was incomplete in using images from ghcr, which resulted in a few places referencing the ghcr build-tools image, while trying to use docker hub credentials. ## Summary of changes Use build-tools image from ghcr consistently.
·
release-compute-8186release-8229
1 parent 86fe26c commit 99639c2

10 files changed

+61
-61
lines changed
 

‎.github/workflows/_benchmarking_preparation.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ jobs:
2727

2828
runs-on: [ self-hosted, us-east-2, x64 ]
2929
container:
30-
image: neondatabase/build-tools:pinned-bookworm
30+
image: ghcr.io/neondatabase/build-tools:pinned-bookworm
3131
credentials:
32-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
33-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
32+
username: ${{ github.actor }}
33+
password: ${{ secrets.GITHUB_TOKEN }}
3434
options: --init
3535

3636
steps:

‎.github/workflows/benchmarking.yml

+36-36
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,10 @@ jobs:
8787

8888
runs-on: ${{ matrix.RUNNER }}
8989
container:
90-
image: neondatabase/build-tools:pinned-bookworm
90+
image: ghcr.io/neondatabase/build-tools:pinned-bookworm
9191
credentials:
92-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
93-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
92+
username: ${{ github.actor }}
93+
password: ${{ secrets.GITHUB_TOKEN }}
9494
options: --init
9595

9696
steps:
@@ -190,10 +190,10 @@ jobs:
190190

191191
runs-on: [ self-hosted, us-east-2, x64 ]
192192
container:
193-
image: neondatabase/build-tools:pinned-bookworm
193+
image: ghcr.io/neondatabase/build-tools:pinned-bookworm
194194
credentials:
195-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
196-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
195+
username: ${{ github.actor }}
196+
password: ${{ secrets.GITHUB_TOKEN }}
197197
options: --init
198198

199199
steps:
@@ -245,10 +245,10 @@ jobs:
245245

246246
runs-on: [ self-hosted, us-east-2, x64 ]
247247
container:
248-
image: neondatabase/build-tools:pinned-bookworm
248+
image: ghcr.io/neondatabase/build-tools:pinned-bookworm
249249
credentials:
250-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
251-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
250+
username: ${{ github.actor }}
251+
password: ${{ secrets.GITHUB_TOKEN }}
252252
options: --init
253253

254254
steps:
@@ -352,7 +352,7 @@ jobs:
352352
region_id_default=${{ env.DEFAULT_REGION_ID }}
353353
runner_default='["self-hosted", "us-east-2", "x64"]'
354354
runner_azure='["self-hosted", "eastus2", "x64"]'
355-
image_default="neondatabase/build-tools:pinned-bookworm"
355+
image_default="ghcr.io/neondatabase/build-tools:pinned-bookworm"
356356
matrix='{
357357
"pg_version" : [
358358
16
@@ -368,18 +368,18 @@ jobs:
368368
"db_size": [ "10gb" ],
369369
"runner": ['"$runner_default"'],
370370
"image": [ "'"$image_default"'" ],
371-
"include": [{ "pg_version": 16, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-freetier", "db_size": "3gb" ,"runner": '"$runner_default"', "image": "'"$image_default"'" },
372-
{ "pg_version": 16, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-new", "db_size": "10gb","runner": '"$runner_default"', "image": "'"$image_default"'" },
373-
{ "pg_version": 16, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-new-many-tables","db_size": "10gb","runner": '"$runner_default"', "image": "'"$image_default"'" },
374-
{ "pg_version": 16, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-new", "db_size": "50gb","runner": '"$runner_default"', "image": "'"$image_default"'" },
375-
{ "pg_version": 16, "region_id": "azure-eastus2", "platform": "neonvm-azure-captest-freetier", "db_size": "3gb" ,"runner": '"$runner_azure"', "image": "neondatabase/build-tools:pinned-bookworm" },
376-
{ "pg_version": 16, "region_id": "azure-eastus2", "platform": "neonvm-azure-captest-new", "db_size": "10gb","runner": '"$runner_azure"', "image": "neondatabase/build-tools:pinned-bookworm" },
377-
{ "pg_version": 16, "region_id": "azure-eastus2", "platform": "neonvm-azure-captest-new", "db_size": "50gb","runner": '"$runner_azure"', "image": "neondatabase/build-tools:pinned-bookworm" },
378-
{ "pg_version": 16, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-sharding-reuse", "db_size": "50gb","runner": '"$runner_default"', "image": "'"$image_default"'" },
379-
{ "pg_version": 17, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-freetier", "db_size": "3gb" ,"runner": '"$runner_default"', "image": "'"$image_default"'" },
380-
{ "pg_version": 17, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-new", "db_size": "10gb","runner": '"$runner_default"', "image": "'"$image_default"'" },
381-
{ "pg_version": 17, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-new-many-tables","db_size": "10gb","runner": '"$runner_default"', "image": "'"$image_default"'" },
382-
{ "pg_version": 17, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-new", "db_size": "50gb","runner": '"$runner_default"', "image": "'"$image_default"'" }]
371+
"include": [{ "pg_version": 16, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-freetier", "db_size": "3gb" ,"runner": '"$runner_default"', "image": "'"$image_default"'" },
372+
{ "pg_version": 16, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-new", "db_size": "10gb","runner": '"$runner_default"', "image": "'"$image_default"'" },
373+
{ "pg_version": 16, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-new-many-tables","db_size": "10gb","runner": '"$runner_default"', "image": "'"$image_default"'" },
374+
{ "pg_version": 16, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-new", "db_size": "50gb","runner": '"$runner_default"', "image": "'"$image_default"'" },
375+
{ "pg_version": 16, "region_id": "azure-eastus2", "platform": "neonvm-azure-captest-freetier", "db_size": "3gb" ,"runner": '"$runner_azure"', "image": "ghcr.io/neondatabase/build-tools:pinned-bookworm" },
376+
{ "pg_version": 16, "region_id": "azure-eastus2", "platform": "neonvm-azure-captest-new", "db_size": "10gb","runner": '"$runner_azure"', "image": "ghcr.io/neondatabase/build-tools:pinned-bookworm" },
377+
{ "pg_version": 16, "region_id": "azure-eastus2", "platform": "neonvm-azure-captest-new", "db_size": "50gb","runner": '"$runner_azure"', "image": "ghcr.io/neondatabase/build-tools:pinned-bookworm" },
378+
{ "pg_version": 16, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-sharding-reuse", "db_size": "50gb","runner": '"$runner_default"', "image": "'"$image_default"'" },
379+
{ "pg_version": 17, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-freetier", "db_size": "3gb" ,"runner": '"$runner_default"', "image": "'"$image_default"'" },
380+
{ "pg_version": 17, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-new", "db_size": "10gb","runner": '"$runner_default"', "image": "'"$image_default"'" },
381+
{ "pg_version": 17, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-new-many-tables","db_size": "10gb","runner": '"$runner_default"', "image": "'"$image_default"'" },
382+
{ "pg_version": 17, "region_id": "'"$region_id_default"'", "platform": "neonvm-captest-new", "db_size": "50gb","runner": '"$runner_default"', "image": "'"$image_default"'" }]
383383
}'
384384
385385
if [ "$(date +%A)" = "Saturday" ] || [ ${RUN_AWS_RDS_AND_AURORA} = "true" ]; then
@@ -457,8 +457,8 @@ jobs:
457457
container:
458458
image: ${{ matrix.image }}
459459
credentials:
460-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
461-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
460+
username: ${{ github.actor }}
461+
password: ${{ secrets.GITHUB_TOKEN }}
462462
options: --init
463463

464464
# Increase timeout to 8h, default timeout is 6h
@@ -642,10 +642,10 @@ jobs:
642642

643643
runs-on: ${{ matrix.RUNNER }}
644644
container:
645-
image: neondatabase/build-tools:pinned-bookworm
645+
image: ghcr.io/neondatabase/build-tools:pinned-bookworm
646646
credentials:
647-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
648-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
647+
username: ${{ github.actor }}
648+
password: ${{ secrets.GITHUB_TOKEN }}
649649
options: --init
650650

651651
steps:
@@ -767,10 +767,10 @@ jobs:
767767

768768
runs-on: [ self-hosted, us-east-2, x64 ]
769769
container:
770-
image: neondatabase/build-tools:pinned-bookworm
770+
image: ghcr.io/neondatabase/build-tools:pinned-bookworm
771771
credentials:
772-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
773-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
772+
username: ${{ github.actor }}
773+
password: ${{ secrets.GITHUB_TOKEN }}
774774
options: --init
775775

776776
# Increase timeout to 12h, default timeout is 6h
@@ -892,10 +892,10 @@ jobs:
892892

893893
runs-on: [ self-hosted, us-east-2, x64 ]
894894
container:
895-
image: neondatabase/build-tools:pinned-bookworm
895+
image: ghcr.io/neondatabase/build-tools:pinned-bookworm
896896
credentials:
897-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
898-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
897+
username: ${{ github.actor }}
898+
password: ${{ secrets.GITHUB_TOKEN }}
899899
options: --init
900900

901901
steps:
@@ -1011,10 +1011,10 @@ jobs:
10111011

10121012
runs-on: [ self-hosted, us-east-2, x64 ]
10131013
container:
1014-
image: neondatabase/build-tools:pinned-bookworm
1014+
image: ghcr.io/neondatabase/build-tools:pinned-bookworm
10151015
credentials:
1016-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
1017-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
1016+
username: ${{ github.actor }}
1017+
password: ${{ secrets.GITHUB_TOKEN }}
10181018
options: --init
10191019

10201020
steps:

‎.github/workflows/build_and_test.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -254,8 +254,8 @@ jobs:
254254
container:
255255
image: ${{ needs.build-build-tools-image.outputs.image }}-bookworm
256256
credentials:
257-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
258-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
257+
username: ${{ github.actor }}
258+
password: ${{ secrets.GITHUB_TOKEN }}
259259
# for changed limits, see comments on `options:` earlier in this file
260260
options: --init --shm-size=512mb --ulimit memlock=67108864:67108864
261261
strategy:

‎.github/workflows/build_and_test_with_sanitizers.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ jobs:
9494
container:
9595
image: ${{ needs.build-build-tools-image.outputs.image }}-bookworm
9696
credentials:
97-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
98-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
97+
username: ${{ github.actor }}
98+
password: ${{ secrets.GITHUB_TOKEN }}
9999
options: --init
100100

101101
steps:

‎.github/workflows/cloud-regress.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ jobs:
3737

3838
runs-on: us-east-2
3939
container:
40-
image: neondatabase/build-tools:pinned-bookworm
40+
image: ghcr.io/neondatabase/build-tools:pinned-bookworm
4141
credentials:
42-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
43-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
42+
username: ${{ github.actor }}
43+
password: ${{ secrets.GITHUB_TOKEN }}
4444
options: --init
4545

4646
steps:

‎.github/workflows/ingest_benchmark.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,10 @@ jobs:
6767
PGCOPYDB_LIB_PATH: /pgcopydb/lib
6868
runs-on: [ self-hosted, us-east-2, x64 ]
6969
container:
70-
image: neondatabase/build-tools:pinned-bookworm
70+
image: ghcr.io/neondatabase/build-tools:pinned-bookworm
7171
credentials:
72-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
73-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
72+
username: ${{ github.actor }}
73+
password: ${{ secrets.GITHUB_TOKEN }}
7474
options: --init
7575
timeout-minutes: 1440
7676

‎.github/workflows/large_oltp_benchmark.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,10 @@ jobs:
5050

5151
runs-on: [ self-hosted, us-east-2, x64 ]
5252
container:
53-
image: neondatabase/build-tools:pinned-bookworm
53+
image: ghcr.io/neondatabase/build-tools:pinned-bookworm
5454
credentials:
55-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
56-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
55+
username: ${{ github.actor }}
56+
password: ${{ secrets.GITHUB_TOKEN }}
5757
options: --init
5858

5959
# Increase timeout to 2 days, default timeout is 6h - database maintenance can take a long time

‎.github/workflows/neon_extra_builds.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ jobs:
9090
container:
9191
image: ${{ needs.build-build-tools-image.outputs.image }}-bookworm
9292
credentials:
93-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
94-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
93+
username: ${{ github.actor }}
94+
password: ${{ secrets.GITHUB_TOKEN }}
9595
options: --init
9696

9797
env:

‎.github/workflows/periodic_pagebench.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ jobs:
3434
pull-requests: write
3535
runs-on: [ self-hosted, small ]
3636
container:
37-
image: neondatabase/build-tools:pinned-bookworm
37+
image: ghcr.io/neondatabase/build-tools:pinned-bookworm
3838
credentials:
39-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
40-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
39+
username: ${{ github.actor }}
40+
password: ${{ secrets.GITHUB_TOKEN }}
4141
options: --init
4242
timeout-minutes: 360 # Set the timeout to 6 hours
4343
env:

‎.github/workflows/pg-clients.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ jobs:
5353
container:
5454
image: ${{ needs.build-build-tools-image.outputs.image }}-bookworm
5555
credentials:
56-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
57-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
56+
username: ${{ github.actor }}
57+
password: ${{ secrets.GITHUB_TOKEN }}
5858
options: --init --user root
5959
services:
6060
clickhouse:
@@ -153,8 +153,8 @@ jobs:
153153
container:
154154
image: ${{ needs.build-build-tools-image.outputs.image }}-bookworm
155155
credentials:
156-
username: ${{ secrets.NEON_DOCKERHUB_USERNAME }}
157-
password: ${{ secrets.NEON_DOCKERHUB_PASSWORD }}
156+
username: ${{ github.actor }}
157+
password: ${{ secrets.GITHUB_TOKEN }}
158158
options: --init --user root
159159

160160
steps:

1 commit comments

Comments
 (1)

github-actions[bot] commented on Mar 18, 2025

@github-actions[bot]
github-actions[bot]
on Mar 18, 2025

8117 tests run: 7723 passed, 0 failed, 394 skipped (full report)

Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 32.3% (8736 of 27024 functions)
  • lines: 48.4% (74868 of 154746 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
99639c2 at 2025-03-18T18:01:18.405Z :recycle:
Please sign in to comment.