-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for some extensions currently not covered by the regression tests #11191
Conversation
7964 tests run: 7581 passed, 0 failed, 383 skipped (full report)Flaky tests (7)Postgres 16
Postgres 15
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
d5cbf29 at 2025-03-18T14:09:13.117Z :recycle: |
…1_tiny_en-src on docker-compose, they require s3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine.
The description of the PR says which can be easily run on top of docker-compose or staging.
I see that you added tests for the docker-compose path but maybe I overlooked it but I don't see that we test these in staging.
I think we shouldn't invest in further tests for extensions without making sure they really work in our cloud environment with neon_superuser derived postgres role neondb_owner
.
If I overlooked it pls point me to where we verify the neon_superuser privileges work fine for these extensions.
We had too many customer reports for other extensions already thet "xxx" doesn't work for extension "yyy" because of missing privileges.
You didn't overlook, the test which can be run on top of staging is not yet ready. I plan to implement it soon using the same tests I added in this PR. I have updated the description to make it clear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests in staging will be done in separate PR, so I can approve this one, now
Problem
Some extensions do not contain tests, which can be easily run on top of docker-compose or staging.
Summary of changes
Added the pg_regress based tests for
pg_tiktoken
,pgx_ulid
,pg_rag
Now they will be run on top of docker-compose, but I intend to adopt them to be run on top staging in the next PRs