Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for some extensions currently not covered by the regression tests #11191

Merged
merged 14 commits into from
Mar 19, 2025

Conversation

a-masterov
Copy link
Contributor

@a-masterov a-masterov commented Mar 12, 2025

Problem

Some extensions do not contain tests, which can be easily run on top of docker-compose or staging.

Summary of changes

Added the pg_regress based tests for pg_tiktoken, pgx_ulid, pg_rag
Now they will be run on top of docker-compose, but I intend to adopt them to be run on top staging in the next PRs

@a-masterov a-masterov changed the title Add a test for pg_tiktoken Add tests for some extensions currently not covered by the regression tests Mar 12, 2025
Copy link

github-actions bot commented Mar 12, 2025

7964 tests run: 7581 passed, 0 failed, 383 skipped (full report)


Flaky tests (7)

Postgres 16

Postgres 15

Code coverage* (full report)

  • functions: 32.3% (8734 of 27025 functions)
  • lines: 48.4% (74876 of 154737 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d5cbf29 at 2025-03-18T14:09:13.117Z :recycle:

@a-masterov a-masterov marked this pull request as ready for review March 18, 2025 14:52
@a-masterov a-masterov requested review from bayandin, a team, hlinnaka and thesuhas and removed request for a team March 18, 2025 14:53
Copy link
Contributor

@Bodobolero Bodobolero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine.
The description of the PR says which can be easily run on top of docker-compose or staging.

I see that you added tests for the docker-compose path but maybe I overlooked it but I don't see that we test these in staging.
I think we shouldn't invest in further tests for extensions without making sure they really work in our cloud environment with neon_superuser derived postgres role neondb_owner.

If I overlooked it pls point me to where we verify the neon_superuser privileges work fine for these extensions.
We had too many customer reports for other extensions already thet "xxx" doesn't work for extension "yyy" because of missing privileges.

@a-masterov
Copy link
Contributor Author

a-masterov commented Mar 18, 2025

The code looks fine. The description of the PR says which can be easily run on top of docker-compose or staging.

I see that you added tests for the docker-compose path but maybe I overlooked it but I don't see that we test these in staging.

You didn't overlook, the test which can be run on top of staging is not yet ready. I plan to implement it soon using the same tests I added in this PR. I have updated the description to make it clear.

Copy link
Contributor

@Bodobolero Bodobolero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests in staging will be done in separate PR, so I can approve this one, now

@a-masterov a-masterov added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit cf9d817 Mar 19, 2025
101 checks passed
@a-masterov a-masterov deleted the amasterov/add-tests-for-extensions branch March 19, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants