chore: fix clippy lints from nightly-2025-03-16 #11273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradludgate
requested review from
DimasKovas,
awarus,
lubennikovaav and
tristan957
conradludgate
commented
Mar 17, 2025
Comment on lines
-874
to
+875
| &mut 0, | ||
| &mut size, |
There was a problem hiding this comment.
This is due to a regression rust-lang/rust#138596
7953 tests run: 7569 passed, 0 failed, 384 skipped (full report)Flaky tests (3)Postgres 17
Postgres 16
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
62212f4 at 2025-03-17T10:43:58.839Z :recycle: |
conradludgate
changed the title
arpad-m
requested changes
Mar 17, 2025
| @@ -96,6 +96,7 @@ enum Message { | |||
|
|
|||
| impl Message { | |||
| /// Convert proto message to internal message. | |||
| #[allow(clippy::result_large_err, reason = "TODO")] | |||
There was a problem hiding this comment.
do we need these reason = fields? to me it seems they can be removed.
There was a problem hiding this comment.
I added them to make it clear that I have not yet considered whether this allow is good or not
awarus
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like to run nightly clippy every so often to make our future rust upgrades easier. Some notable changes:
Prefer
next_back()overlast(). Generic iterators will implementlast()to run forward through the iterator until the end.Prefer
io::Error::other().Use implicit returns
One case where I haven't dealt with the issues is the now more-sensitive "large enum variant" lint. I chose not to take any decisions around it here, and simply marked them as allow for now.