pageserver/secondary: deregister IO metrics #11283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stash the request context to be used for downloads in `SecondaryTimelineDetail`. These objects match the lifetime of the secondary location pretty well. When the timeline is removed, deregister the metrics too.
7975 tests run: 7586 passed, 0 failed, 389 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
a763ab2 at 2025-03-17T19:03:25.034Z :recycle: |
VladLazar
changed the title
jcsp
reviewed
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
IO metrics for secondary locations do not get deregistered when the timeline is removed.
Summary of changes
Stash the request context to be used for downloads in
SecondaryTimelineDetail. These objects match the lifetime of thesecondary timeline location pretty well.
When the timeline is removed, deregister the metrics too.
Closes #11156