feat(compute_ctl): pass compute type to pageserver with pg_options #11287
+174
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
force-pushed
the
skyzh/compute-passthrough-try-2
branch
from
86dd34f to
d60fa40
Compare
|
If this PR added a GUC in the Postgres fork or If you're an external contributor, a Neon employee will assist in |
tristan957
reviewed
Mar 17, 2025
| @@ -2549,6 +2549,40 @@ where | |||
| if let Some(app_name) = params.get("application_name") { | |||
| Span::current().record("application_name", field::display(app_name)); | |||
| } | |||
| if let Some(options) = params.get("options") { | |||
There was a problem hiding this comment.
Would it be better to just parse it with clap?
There was a problem hiding this comment.
there's also -cXXX which I just fixed, this syntax is not supported by clap.
tristan957
reviewed
Mar 17, 2025
7964 tests run: 7580 passed, 0 failed, 384 skipped (full report)Flaky tests (4)Postgres 17
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
7a9fe7b at 2025-03-18T22:20:34.625Z :recycle: |
Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
force-pushed
the
skyzh/compute-passthrough-try-2
branch
from
d643af6 to
7a9fe7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
second try of #11185, part of https://github.com/neondatabase/cloud/issues/24706
Summary of changes
Tristan reminded me of the
optionsfield of the pg wire protocol, which can be used to pass configurations. This patch adds the parsing on the pageserver side, and suppliesneon.endpoint_typeas part of theoptions.