storcon: also support tenant deletion for safekeepers #11289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7964 tests run: 7580 passed, 0 failed, 384 skipped (full report)Flaky tests (2)Postgres 17
Postgres 16
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
d72f1ec at 2025-03-19T16:09:39.238Z :recycle: |
arpad-m
force-pushed
the
arpad/storcon_delete_tenant
branch
from
3c3cbbf to
937da2f
Compare
arssher
reviewed
Mar 18, 2025
There was a problem hiding this comment.
Put some comments, but it would be more natural to finish https://neondb.slack.com/archives/C04KGFVUWUQ/p1742298363579099?thread_ts=1742297769.832709&cid=C04KGFVUWUQ
and
https://neondb.slack.com/archives/C04KGFVUWUQ/p1742287892184099
first.
Otherwise lgtm, it is in the right direction.
arssher
approved these changes
Mar 19, 2025
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a tenant gets deleted, delete also all of its timelines. We assume that by the time a tenant is being deleted, no new timelines are being created, so we don't need to worry about races with creation in this situation.
Unlike #11233, which was very simple because it listed the timelines and invoked timeline deletion, this PR obtains a list of safekeepers to invoke the tenant deletion on, and then invokes tenant deletion on each safekeeper that has one or multiple timelines.
Alternative to #11233
Builds on #11288
Part of #9011