Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: improve debuggability of timeline creation failures during chaos testing #11300

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Mar 18, 2025

Problem

We're seeing timeline creation failures that look suspiciously like some race with the cleanup-deletion of initdb temporary directories. I couldn't spot the bug, but we can make it a bit easier to debug.

Related: #11296

Summary of changes

  • Avoid surfacing distracting ENOENT failure to delete as a log error -- this is fine, and can happen if timeline is cancelled while doing initdb, or if initdb itself has an error where it doesn't write the dir (this error is surfaced separately)
  • Log after purging initdb temp directories

@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels Mar 18, 2025
@jcsp jcsp marked this pull request as ready for review March 18, 2025 18:34
@jcsp jcsp requested a review from a team as a code owner March 18, 2025 18:34
@jcsp jcsp requested a review from VladLazar March 18, 2025 18:34
Copy link

7964 tests run: 7580 passed, 0 failed, 384 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 32.3% (8739 of 27024 functions)
  • lines: 48.4% (74898 of 154749 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6ba109d at 2025-03-18T18:46:03.376Z :recycle:

@jcsp jcsp added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit 55cb07f Mar 19, 2025
109 checks passed
@jcsp jcsp deleted the jcsp/issue-11296-initdb-deletions branch March 19, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants