Improve comments in page cache, to explain the use of async. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlinnaka
force-pushed
the
page_cache-async-cleanup
branch
8 times, most recently
from
69d69b8 to
e45b761
Compare
It was only marked as async because it calls relsize_get(), but relsize_get() will in fact never block when it's called with the max LSN value, like put_wal_record() does. Refactor to avoid marking put_wal_record() as 'async'.
Explain the mix of async and other functions in the page cache.
hlinnaka
force-pushed
the
page_cache-async-cleanup
branch
from
e45b761 to
5e0cc89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will likely refactor/rewrite this, see #58, but let's try to document the status quo first.