fix(golangci_lint_ls): disable all output formats except JSON#4247
Merged
justinmk merged 1 commit intoneovim:masterfrom Jan 27, 2026
Merged
fix(golangci_lint_ls): disable all output formats except JSON#4247justinmk merged 1 commit intoneovim:masterfrom
justinmk merged 1 commit intoneovim:masterfrom
Conversation
Contributor
Author
|
I've put this back to a draft to explore other options, like golangci/golangci-lint#6273. |
Contributor
Author
|
The "other options" I was exploring turn out to take rather more time than expected and it's unclear to where to go from there. In favor of preventing others to run into issue it might be fine to go with this iteration. |
69a9b40 to
ba7d43c
Compare
This change set enables all possible output formats that exist for golangci-lint. This is necessary because if a user configures output formats in their `.golangci.yml` configuration (for example for CI) then this is always in addition to the ones enabled on the command line. Therefore, we manually disable all possible output formats. Currently, there doesn't exist a `golangci-lint` option to exclusively enable an output format or disable all from the config.
ba7d43c to
f89c5c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change set enables all possible output formats that exist for golangci-lint. This is necessary because if a user configures output formats in their
.golangci.ymlconfiguration (for example for CI) then this is always in addition to the ones enabled on the command line. Therefore, we manually disable all possible output formats.Currently, there doesn't exist a
golangci-lintoption to exclusively enable an output format or disable all from the config.