Skip to content

fix(golangci_lint_ls): disable all output formats except JSON#4247

Merged
justinmk merged 1 commit intoneovim:masterfrom
timofurrer:golangci-lint-ls-output-cfgs
Jan 27, 2026
Merged

fix(golangci_lint_ls): disable all output formats except JSON#4247
justinmk merged 1 commit intoneovim:masterfrom
timofurrer:golangci-lint-ls-output-cfgs

Conversation

@timofurrer
Copy link
Contributor

This change set enables all possible output formats that exist for golangci-lint. This is necessary because if a user configures output formats in their .golangci.yml configuration (for example for CI) then this is always in addition to the ones enabled on the command line. Therefore, we manually disable all possible output formats.

Currently, there doesn't exist a golangci-lint option to exclusively enable an output format or disable all from the config.

@timofurrer timofurrer marked this pull request as draft December 19, 2025 11:13
@timofurrer
Copy link
Contributor Author

I've put this back to a draft to explore other options, like golangci/golangci-lint#6273.

@timofurrer
Copy link
Contributor Author

The "other options" I was exploring turn out to take rather more time than expected and it's unclear to where to go from there. In favor of preventing others to run into issue it might be fine to go with this iteration.

@timofurrer timofurrer marked this pull request as ready for review January 9, 2026 12:23
@timofurrer timofurrer force-pushed the golangci-lint-ls-output-cfgs branch from 69a9b40 to ba7d43c Compare January 9, 2026 12:24
@timofurrer timofurrer changed the title golangci_lint_ls: disable all output formats except JSON fix(golangci_lint_ls): disable all output formats except JSON Jan 9, 2026
This change set enables all possible output formats that exist for
golangci-lint. This is necessary because if a user configures output
formats in their `.golangci.yml` configuration (for example for CI) then
this is always in addition to the ones enabled on the command line.
Therefore, we manually disable all possible output formats.

Currently, there doesn't exist a `golangci-lint` option to exclusively
enable an output format or disable all from the config.
@timofurrer timofurrer force-pushed the golangci-lint-ls-output-cfgs branch from ba7d43c to f89c5c7 Compare January 9, 2026 12:24
@justinmk justinmk merged commit 86a933b into neovim:master Jan 27, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments