dockerization #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I'd be happy to test & merge. However, I'm not super familiar with docker and haven't used it for a while. Would you mind adding some instructions to the README? |
Author
|
Thanks, Lets me ping you once I have made the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, really like the paper and love your drake workflow. Thought I can borrow some of the ideas. Also, I dockerized your setup in case you want to develop inside docker. I find that useful, don't know if you do as well. Feel free to ignore.
Changes,
changes submodules to have https instead of ssh links. Do let me know if this is a deal I can change it back.