Add support mip nerf in training example#129
Open
foreverYoungGitHub wants to merge 5 commits intonerfstudio-project:masterfrom
Open
Add support mip nerf in training example#129foreverYoungGitHub wants to merge 5 commits intonerfstudio-project:masterfrom
foreverYoungGitHub wants to merge 5 commits intonerfstudio-project:masterfrom
Conversation
Author
|
@liruilong940607 @tancik I'm wondering if you can take a look at it when you are available? |
Collaborator
|
Hey thanks for the implementation! I quickly skimmed it and it looks all reasonable! I will take a close look in the weekend. |
Author
|
That would be super helpful! Thank you Li! |
| parser.add_argument( | ||
| "--data_root", | ||
| type=str, | ||
| default=str(pathlib.Path.home() / "data"), |
Contributor
There was a problem hiding this comment.
you might miss importing the pathlib at the beginning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, @liruilong940607,
Thanks for your awesome work!
I just add the support for training the mip nerf (kind of) with nerfacc based on your discussion at #88. I did a quick test for the lego scene with 1 t4 and this is the full logs:
The training time is pretty similar with vanilla nerf and the performance is almost same as well (which I do expect slightly better performance).
It would be nice if you can take a look at it when you are available!
Thank you in advance!
Btw, this pr also changes the dataset root dir to an argument for easier usage 😉