Redirect even when authData is present #505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neroniaky do docs need updated to describe the behavior? |
Currently if authData is present, the canActivate guard will not redirect to the redirect path stored in localStorage. Now, canActivate will attempt to redirect based on authData and the value of the expiry key.
|
@rrjohnson85 thanks for this PR. I don't think we have anything in the docs about this behaviour, but a clarification would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently if authData is present, the canActivate guard will not store the redirect route path in localStorage.
Issue Number: #491
What is the new behavior?
Now, canActivate will attempt to store the redirect route path in local storage based on authData and the value of the expiry key.
Does this PR introduce a breaking change?
[ ] Yes
[x] No