Handle private channel hop hints #487
Conversation
…into handle-private-channel-hop-hints
contrun
force-pushed
the
handle-private-channel-hop-hints
branch
from
8f14f6b to
3dd662a
Compare
| pub channel_outpoint: OutPoint, | ||
|
|
There was a problem hiding this comment.
any special reason to change from tx hash to channel outpoint?
There was a problem hiding this comment.
Only to be more consistent with other source code in the code base. Either tx hash or outpoint is fine for me. We just need to be consistent.
|
|
||
| assert!(res.is_ok(), "Send payment failed: {:?}", res); |
There was a problem hiding this comment.
from the code in find_path, seems we will first try to pick channels with hint, should we add unit test for channels with and without hint, and make sure channels with hint will be selected?
There was a problem hiding this comment.
As discussion on discord, the decision is that
那就还是简单点？ hints 的意思就是 hints，真正用的 payment path 可能就是不采用这些 hints。用户想要限制使用某些路径就用 send_to_route
| } | ||
|
|
||
| // #[tokio::test] | ||
| // async fn test_send_payment_with_route_to_self_with_hop_hints() { | ||
| // init_tracing(); |
There was a problem hiding this comment.
we expect to add these tests back after we have send_to_route?
This PR depends on Use the fee rate in oubound channel to calculate the TLC fee by contrun · Pull Request #489 · nervosnetwork/fiber.
The migration code is not well-tested. I only tried the following.
git checkout v0.3.1to checkout to the v0.3.1 version code.REMOVE_OLD_STATE=y ./tests/nodes/start.shto start a few fnn nodes with all new states.(cd ./tests/bruno; npm exec -- @usebruno/[email protected] run e2e/router-pay -r --env test)to create a few payment sessions.ldb --db=tests/nodes/1/fiber/store --secondary_path=/tmp/test/ dump --hex | awk '/0xC0/ {print $1}' | sed 's/0xC0/0x/g'to see all the payment sessions created.ldb --db=tests/nodes/1/fiber/store --secondary_path=/tmp/test/ dump --hex | awk '/0xC0/ {print $1}' | sed 's/0xC0/0x/g' | xargs -I __ curl -sS --json '{"id": "42", "jsonrpc": "2.0", "method": "get_payment", "params": [{"payment_hash": "__"}]}' http://127.0.0.1:21714/ | jq -sto see all the payment session detailed information.git checkout handle-private-channel-hop-hintsto checkout the code of this PR.(cd migrate; cargo run -- --path ../tests/nodes/1/fiber/store)to start migration.cargo build && (clear; cd ./tests/nodes/; ../../target/debug/fnn -d 1)to start node 1.ldb --db=tests/nodes/1/fiber/store --secondary_path=/tmp/test/ dump --hex | awk '/0xC0/ {print $1}' | sed 's/0xC0/0x/g' | xargs -I __ curl -sS --json '{"id": "42", "jsonrpc": "2.0", "method": "get_payment", "params": [{"payment_hash": "__"}]}'again to check the payment session data have been migrated (by eyes).