Skip to content

Remove unused variable #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unused variable #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions odetoolbox/system_of_shapes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,10 +255,9 @@ def generate_propagator_solver(self, disable_singularity_detection: bool = False
# generate symbols for each nonzero entry of the propagator matrix
#

P_sym = sympy.zeros(*P.shape) # each entry in the propagator matrix is assigned its own symbol
P_expr = {} # the expression corresponding to each propagator symbol
update_expr = {} # keys are str(variable symbol), values are str(expressions) that evaluate to the new value of the corresponding key
for row in range(P_sym.shape[0]):
for row in range(P.shape[0]):
# assemble update expression for symbol ``self.x_[row]``
if not _is_zero(self.c_[row]):
raise PropagatorGenerationException("For symbol " + str(self.x_[row]) + ": nonlinear part should be zero for propagators")
Expand All @@ -267,10 +266,9 @@ def generate_propagator_solver(self, disable_singularity_detection: bool = False
raise PropagatorGenerationException("For symbol " + str(self.x_[row]) + ": higher-order inhomogeneous ODEs are not supported")

update_expr_terms = []
for col in range(P_sym.shape[1]):
for col in range(P.shape[1]):
if not _is_zero(P[row, col]):
sym_str = Config().propagators_prefix + "__{}__{}".format(str(self.x_[row]), str(self.x_[col]))
P_sym[row, col] = sympy.parsing.sympy_parser.parse_expr(sym_str, global_dict=Shape._sympy_globals)
P_expr[sym_str] = P[row, col]
if row != col and not _is_zero(self.b_[col]):
# the ODE for x_[row] depends on the inhomogeneous ODE of x_[col]. We can't solve this analytically in the general case (even though some specific cases might admit a solution)
Expand Down