Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated import #3169

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore: remove deprecated import #3169

merged 1 commit into from
Dec 20, 2024

Conversation

kasir-barati
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

image
Import from a deprecated lib.

Issue Number: #3167

What is the new behavior?

  • Import from @apollo/server.
  • Prettier converted single quote to double quote.
  • I had to pass context type to GraphQLRequestListener.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N/A.

@kasir-barati kasir-barati mentioned this pull request Dec 19, 2024
Closed
5 tasks
@kasir-barati
Copy link
Contributor Author

Ready for Code Review.

@kamilmysliwiec kamilmysliwiec merged commit 32203b0 into nestjs:master Dec 20, 2024
4 checks passed
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasir-barati @kamilmysliwiec