Skip to content

docs(fundamentals): add discovery service documentation #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 25, 2025

Conversation

vahidvdn
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

There is nothing about DiscoveryService

What is the new behavior?

Explained DiscoveryService with possible examples and use cases

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@vahidvdn vahidvdn changed the title docs: add discovery service documentation docs(fundamentals): add discovery service documentation Mar 11, 2025
@vahidvdn
Copy link
Contributor Author

@kamilmysliwiec Do you have any idea why the ci is failing?

@micalevisk
Copy link
Member

micalevisk commented Mar 23, 2025

do you mind on addressing the issue #2876 here as well?

I guess we don't need to have an example using SetMetadata directly, in favor of DiscoveryService.createDecorator one as it is too low level.

@kamilmysliwiec
Copy link
Member

@vahidvdn feel free to ignore the lighthouse ci test

@vahidvdn
Copy link
Contributor Author

@micalevisk Good idea! I just updated accordingly. Thank you for your suggestion.
Could you please check it out?

@kamilmysliwiec kamilmysliwiec merged commit 311b081 into nestjs:master Mar 25, 2025
4 of 5 checks passed
@kamilmysliwiec
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants