Fix schema definition for federation 2 @link in schema-first#3112
Open
burn2delete wants to merge 1 commit intonestjs:masterfrom
Open
Fix schema definition for federation 2 @link in schema-first#3112burn2delete wants to merge 1 commit intonestjs:masterfrom
burn2delete wants to merge 1 commit intonestjs:masterfrom
Conversation
burn2delete
force-pushed
the
schema-first-fed2-link-fix
branch
from
a3d9842 to
9ee939f
Compare
burn2delete
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update graphql-federation-definitions.factory.ts
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
schema definition and use of
@linkis not included in the SDL for the schema in schema-first approachIssue Number: N/A
What is the new behavior?
schema definition and use of
@linkis properly included in the SDL for the subgraphDoes this PR introduce a breaking change?
Other information