Skip to content

[management] Make startup period configurable #3767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025

Conversation

pascal-fischer
Copy link
Collaborator

Describe your changes

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@Copilot Copilot AI review requested due to automatic review settings April 30, 2025 14:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes the startup period of the peer update process configurable and updates the environment variable names accordingly.

  • Renamed the environment variable from PEER_UPDATE_INTERVAL_MS to NB_PEER_UPDATE_INTERVAL_MS.
  • Introduced a new configurable startup delay via NB_PEER_UPDATE_STARTUP_PERIOD_S instead of a fixed 30-second wait.
Comments suppressed due to low confidence (1)

management/server/account.go:213

  • The computed variable 'initialInterval' is never used; consider using 'initialInterval' for storing the buffer interval or removing it if not needed, to avoid potential confusion about the intended interval value.
am.updateAccountPeersBufferInterval.Store(int64(time.Duration(interval) * time.Millisecond))

Copy link
Contributor

@crn4 crn4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascal-fischer pascal-fischer merged commit f1de8e6 into main May 16, 2025
35 checks passed
@pascal-fischer pascal-fischer deleted the feature/startup-configurable branch May 16, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants