[management] Skip adding existing users to domain account

[bcmmbaga]

Describe your changes

Issue ticket number and link

Stack

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)
• Extended the README / documentation, if necessary

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull Request Overview

This PR refactors account creation and user management by modifying the account creation flow and enhancing error handling when adding a user to a domain account. The changes include a new test (TestDefaultAccountManager_AddNewUserToDomainAccount) to verify user addition behavior and updates to the logic in newAccount and addNewUserToDomainAccount for clearer error handling and existence checks.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
management/server/account_test.go	Added a new test to validate behavior for adding both existing and new users to a domain account.
management/server/account.go	Refactored newAccount to use a dedicated existence check and improved error handling in addNewUserToDomainAccount.

Comments suppressed due to low confidence (2)

management/server/account.go:486

• Consider including the accountId in the warning log message to provide clearer context during retries.

log.WithContext(ctx).Warnf("an account with ID already exists, retrying...")

management/server/account.go:1046

• [nitpick] Consider renaming 'addNewUserToDomainAccount' to 'AddUserToDomainAccount' to better reflect its behavior of handling both new and existing users.

func (am *DefaultAccountManager) addNewUserToDomainAccount(ctx context.Context, domainAccountID string, userAuth nbcontext.UserAuth) (string, error) {