[client, android] Fix/android enable server route #3806
Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an Android bug by enabling the server route, eliminating the previous error that caused the engine to restart on Android.
- Removed the Android-specific server router file (server_android.go) that previously returned an error.
- Removed the build tag in server.go to include Android in the supported platforms.
- Updated notifier code to filter out dynamic (domain) routes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| client/internal/routemanager/server_android.go | Removed the file that previously blocked server routes on Android. |
| client/internal/routemanager/server.go | Removed the Android exclusion build tag to enable support in this file. |
| client/internal/routemanager/notifier/notifier.go | Added filtering logic for domain (dynamic) routes in client routes. |
Comments suppressed due to low confidence (1)
client/internal/routemanager/server.go:1
- [nitpick] Since the removal of the Android exclusion build tag now enables the server route on Android, please ensure that any platform-specific differences are documented accordingly.
package routemanager
| @@ -32,6 +32,10 @@ func (n *Notifier) SetListener(listener listener.NetworkChangeListener) { | |||
| func (n *Notifier) SetInitialClientRoutes(clientRoutes []*route.Route) { | |||
| nets := make([]string, 0) | |||
| for _, r := range clientRoutes { | |||
| // filter out domain routes | |||
There was a problem hiding this comment.
[nitpick] Consider clarifying in the comment that 'dynamic' specifically refers to routes based on domains to improve maintainability and clarity for future reviewers.
| // filter out domain routes | |
| // Filter out routes that are dynamic, specifically those based on domains |
Copilot uses AI. Check for mistakes.
Describe your changes
Enable the server route; otherwise, the manager throws an error and the engine will restart.
Issue ticket number and link
Stack
Checklist