Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Eaton 9SX5KIRT and 9SXEBM180RT #2626

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

issue
Copy link
Contributor

@issue issue commented Jan 10, 2025

No description provided.

model: 9SX5KIRT
slug: eaton-9sx5kirt
u_height: 3
is_full_depth: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for your contribution! In an attempt to have the most accurate and complete data we can, I have a few additional data points we would like you to add if possible.

  1. Please add the airflow data point if you have it or can find it. Often these are listed in the datasheet, but sometimes they are not
  2. Please add the weight and associated weight_unit data point if you have it or can find it. Often these are listed in the datasheet, but sometimes they are not

If you have any questions, please let us know :)

Comment on lines +45 to +49
interfaces:
- name: Battery connector
type: other
- name: Battery detection
type: other
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not meant for battery connectors, it is meant for network interfaces. These might be better defined as module-bays

slug: eaton-9sxebm180rt
part_number: 9SXEBM180RT
u_height: 3
is_full_depth: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for your contribution! In an attempt to have the most accurate and complete data we can, I have a few additional data points we would like you to add if possible.

  1. Please add the weight and associated weight_unit data point if you have it or can find it. Often these are listed in the datasheet, but sometimes they are not

If you have any questions, please let us know :)

Comment on lines +13 to +23
interfaces:
- name: Battery connector, top
type: other
- name: Battery detection, left
type: other
label: Batt detection
- name: Battery connector, down
type: other
- name: Battery detection, right
type: other
label: Batt detection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again these are not meant for this, they are meant for networking interfaces. Maybe define these as module-bays and create the associated batteries as modules

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cropping is not acceptable, it will not look good in the interface. Please try to make this straight or find a better image. Thank you

@danner26 danner26 marked this pull request as draft January 10, 2025 15:32
@danner26 danner26 added the status: revisions needed This issue requires additional information to be actionable label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: revisions needed This issue requires additional information to be actionable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants