fix(module): hpe power supply duplicate model #3760
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a duplicate model name issue where two different HPE power supply part numbers (748287-B21 and 578322-B21) previously shared the identical model name "HPE 1200W Common Slot Platinum Hot Plug Power Supply". The fix disambiguates them by appending their respective part numbers in parentheses.
Key changes:
- Appends "(748287-B21)" to the model name in 748287-B21.yaml
- Appends "(578322-B21)" to the model name in 578322-B21.yaml
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| module-types/HPE/748287-B21.yaml | Updates model name to include part number in parentheses to resolve duplication |
| module-types/HPE/578322-B21.yaml | Updates model name to include part number in parentheses to resolve duplication |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
harryajc
approved these changes
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #3754