Skip to content

[v6] Prevent failures and restarts of deployments #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2025
Merged

[v6] Prevent failures and restarts of deployments #601

merged 2 commits into from
May 6, 2025

Conversation

LeoColomb
Copy link
Member

Note

Kinda big feature and bring a additionnal container image to the chart, thus bumping minor version.

  1. Increase startup probe failure threshold
  2. Add an initial container to the worker deployment so it waits for main deployment to be ready before spinning in.

Fixes #581

@LeoColomb LeoColomb mentioned this pull request Apr 5, 2025
Closed
@LeoColomb LeoColomb force-pushed the leo/fix/worker branch 3 times, most recently from 01b1d89 to a5c0fd2 Compare April 24, 2025 22:59
@LeoColomb LeoColomb requested a review from RangerRick April 24, 2025 23:00
@LeoColomb LeoColomb added this to the 6.0.0 milestone May 5, 2025
RangerRick
RangerRick approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@RangerRick RangerRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dig this a lot! nice clean way to do it

@LeoColomb LeoColomb changed the base branch from main to release/6.x.x May 6, 2025 15:01
@LeoColomb LeoColomb changed the title Prevent failures and restarts of deployments [v6] Prevent failures and restarts of deployments May 6, 2025
This was referenced May 6, 2025
Merged
Closed
@LeoColomb LeoColomb merged commit 34d01f7 into release/6.x.x May 6, 2025
2 checks passed
@LeoColomb LeoColomb deleted the leo/fix/worker branch May 6, 2025 15:26
LeoColomb added a commit that referenced this pull request May 6, 2025
@LeoColomb
[v6] Prevent failures and restarts of deployments (#601)
36524de 
Fixes #581
LeoColomb added a commit that referenced this pull request May 6, 2025
@LeoColomb
[v6] Prevent failures and restarts of deployments (#601)
062f21b 
Fixes #581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RangerRick RangerRick RangerRick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

netbox and netbox-worker pods in crash loop on 5.0.48
2 participants
@LeoColomb @RangerRick