-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fixes: #15924 - Prevent API payload from allowing tagged_vlans while interface mode is set to tagged-all #17211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arthanson
merged 20 commits into
feature
from
15924-fix-api-interface-patch-tagged-all-mode
Feb 26, 2025
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
5c9a145
Fixes: #15924 - Prevent API payload from allowing tagged_vlans while …
DanSheps 282836c
Prevent cleanup of tagged_vlans when no tagged_vlans set on interface
DanSheps 4ea0047
Fix test errors
DanSheps d4c8e88
Remove accidental debug statements
DanSheps bab5a5b
Update validation to model clean method instead of serializer
DanSheps 4f830ce
Remove clearing of tagged vlans from `save()`
DanSheps d159547
Make changes to validation to account for M2M not being available und…
DanSheps 9a13caa
Optimize untagged vlan check
DanSheps 07444e6
Re-ordering statements in validators
DanSheps 5776db6
Forgot to call super().clean()
DanSheps 140d552
Merge branch 'feature' of https://github.com/netbox-community/netbox …
DanSheps 1789862
Adjust logic for form and serializer. Add tests
DanSheps 8dd6119
Merge branch 'feature' of https://github.com/netbox-community/netbox …
DanSheps 365e2fb
Fix test failure
DanSheps afb748c
Merge branch 'feature' of https://github.com/netbox-community/netbox …
DanSheps e858706
Fix ruff errors
DanSheps 79262c6
Fix test by removing now invalid test
DanSheps 8ee5d0a
Update serializer, form and tests
DanSheps 2c08258
Optimize API test for vlan fields
DanSheps 41e6a55
Optimize API serializer logic
DanSheps File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.