Skip to content

feat: adds oauth2 authentication #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 17, 2025
Merged

feat: adds oauth2 authentication #40

merged 17 commits into from
Apr 17, 2025

Conversation

jajeffries
Copy link
Contributor

Adds oauth2 authentication using diode's token endpoint.

Note: the authentication metadata/header has to be lowercase as grpc requires header keys to be lowercase.

Copy link

github-actions bot commented Apr 15, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/site-packages/netboxlabs/diode/sdk
   client.py186498%75, 240, 275, 299
TOTAL218498% 

Tests Skipped Failures Errors Time
92 0 💤 0 ❌ 0 🔥 0.990s ⏱️

@jajeffries jajeffries changed the title adds oauth2 authentication feat: adds oauth2 authentication Apr 15, 2025
@jajeffries jajeffries changed the base branch from develop to update_datamodel April 15, 2025 13:27
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Apr 15, 2025
@jajeffries jajeffries requested a review from mfiedorowicz April 16, 2025 07:44
@jajeffries
Copy link
Contributor Author

Refactored error handling. Removed returning None to keep consistent with existing behaviour.

Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments worth checking

@jajeffries jajeffries requested a review from mfiedorowicz April 17, 2025 15:44
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@jajeffries jajeffries merged commit 07cccc8 into update_datamodel Apr 17, 2025
3 checks passed
@jajeffries jajeffries deleted the oauth2 branch April 17, 2025 19:23
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants