feat: add OAuth2 diode:ingest scope to authentication process #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Fiedorowicz <[email protected]>
mfiedorowicz
changed the title
Signed-off-by: Michal Fiedorowicz <[email protected]>
ltucker
approved these changes
Apr 23, 2025
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for OAuth2 scopes in the
DiodeClientauthentication flow, specifically adding thediode:ingestscope for ingestion operations. The changes include updates to the client code to handle scopes and modifications to the test suite to validate the new functionality.Authentication Enhancements:
_OAUTH2_INGEST_SCOPEfor thediode:ingestscope innetboxlabs/diode/sdk/client.py. This scope is now passed during authentication for ingestion operations. [1] [2]_authenticatemethod to accept ascopeparameter and pass it to the_DiodeAuthenticationclass._DiodeAuthenticationclass to include ascopeattribute and ensure the scope is sent in the OAuth2 token request. [1] [2]Test Updates:
tests/test_client.pyto include thescope="diode:ingest"parameter when initializing_DiodeAuthentication. This ensures the new scope functionality is properly tested. [1] [2] [3] [4]