Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove got.js utility #6249

Closed
wants to merge 20 commits into from

Conversation

hereje
Copy link
Contributor

@hereje hereje commented Dec 5, 2023

Summary

remove got.js utility so that it is no longer referenced

note: merge after all PR related to #5695 have been merged.

related to #5695


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

remove got.js utility so that it is no longer referenced

related to netlify#5695
Copy link

github-actions bot commented Dec 5, 2023

📊 Benchmark results

Comparing with 485aabd

  • Dependency count: 1,283 (no change)
  • Package size: 282 MB ⬇️ 0.00% decrease vs. 485aabd
  • Number of ts-expect-error directives: 1,180 (no change)

@hereje hereje marked this pull request as ready for review December 15, 2023 14:27
@hereje hereje requested a review from a team as a code owner December 15, 2023 14:27
Copy link
Contributor

@TylerBarnes TylerBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like tests are failing on import got from '../../utils/got.js'

@TylerBarnes
Copy link
Contributor

@hereje the tests failed again. Looks like got is still used as of now so we can't merge this PR

@hereje
Copy link
Contributor Author

hereje commented Feb 28, 2024

@hereje the tests failed again. Looks like got is still used as of now so we can't merge this PR

I forgot to mention, this PR must be merged after all PR related to #5695 have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants