refactor: refactor typescript types from build-info and related parts #6269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
approved these changes
Dec 20, 2023
| @@ -7,14 +7,9 @@ | |||
| * Instead, we return that the feature flag is enabled if it isn't | |||
| * specifically set to false in the response | |||
| * @param {*} siteInfo | |||
| * @param {string} flagName | |||
| * | |||
| * @returns {boolean} | |||
| */ | |||
| // @ts-expect-error TS(7006) FIXME: Parameter 'flagName' implicitly has an 'any' type. | |||
There was a problem hiding this comment.
nit: this error message is probably not correct anymore
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
This is a prerequisite before performing the actual change
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)