refactor: move compiled artefacts to dist folder #6272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
reviewed
Dec 21, 2023
|
@lukasholzer I'm taking a look at this as part of CT-312 so will get this branch up to date with the latest changes in main |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -151,7 +151,7 @@ | |||
|
|
|||
| if (acceptsHtml) { | |||
| response.setHeader('Content-Type', 'text/html') | |||
| response.end(await renderErrorTemplate(errorString, './templates/function-error.html', 'function')) | |||
| response.end(await renderErrorTemplate(errorString, '../../src/lib/templates/function-error.html', 'function')) | |||
Check warning
Code scanning / CodeQL
Information exposure through a stack trace
khendrikse
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Moves the compiled artefacts to the dist folder and aligns it with other TypeScript projects at netlify.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)