feat: pass feature flags down to netlify build on dev #6291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasholzer
commented
Jan 9, 2024
Comment on lines
-101
to
-106
| const getFeatureFlagsFromSiteInfo = (siteInfo) => ({ | ||
| ...siteInfo.feature_flags, | ||
| // see https://github.com/netlify/pod-dev-foundations/issues/581#issuecomment-1731022753 | ||
| zisi_golang_use_al2: isFeatureFlagEnabled('cli_golang_use_al2', siteInfo), | ||
| }) | ||
|
|
There was a problem hiding this comment.
just moved to the feature-flag.ts file and fixed the object destruction as feature_flags is undefined on sites that are not linked
|
|
Skn0tt
approved these changes
Jan 9, 2024
lukasholzer
deleted the
feat/pass-feature-flags-to-netlify-build-on-dev
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
This is needed to rollout the next runtime version in the CLI through the feature flags as well
Fixes https://linear.app/netlify/issue/FRA-139/rollout-the-new-runtime
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)