fix: cache edge function dependency tracing #6440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
requested review from
JGAntunes and
Skn0tt
and removed request for
a team
📊 Benchmark resultsComparing with 10965ab
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #6276, we have started to trace transitive dependencies of edge function files for the purpose of hot reloading. This has introduced a regression where, for non-trivial dependency trees, we'll get into an infinite loop trying to recursively trace the dependencies of interdependent files.
This PR addresses that by ensuring we don't trace the same file twice.
Fixes COM-506.