feat(utils): replace fastify and express with tinyhttp and friends #7050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talentlessguy
changed the title
…tlessguy/cli into remove-fastify-and-express
talentlessguy
changed the title
serhalp
reviewed
Feb 28, 2025
| await server.listen({ port: settings.frameworkPort }) | ||
| const [address] = server.addresses() | ||
|
|
||
| const server = createServer((req, res) => app.handler(req as Request, res as Response)) |
There was a problem hiding this comment.
Type assertions are unsafe. Why is there a mismatch here? How can we resolve it?
There was a problem hiding this comment.
tinyhttp's Request and Response extend node:http's Request and Response. Probably could pass as a generic to createServer but if I recall correctly, it throws a type error
There was a problem hiding this comment.
this is a TypeScript issue with extension depth. Request extends IncomingMessage, which itself extends Stream. TypeScript thinks that Request doesn't extend Stream because of that, even though it does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Replaces express, express-loggin, fastify and fastify-static with tinyhttp, @tinyhttp/logger, sirv and milliparsec
See e18e/ecosystem-issues#156
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)