NETOBSERV-2418: new FlowCollectorSlice API #2171

jotak · 2025-11-21T15:02:35Z

Description

First commit is just the API definition (CRD) and the related boilerplate
Second commit is the actual implementation

TODO:

~~Some tests!~~

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

openshift-ci-robot · 2025-11-21T15:02:39Z

openshift-ci-robot · 2025-11-21T16:20:16Z

openshift-ci-robot · 2025-11-21T16:30:13Z

openshift-ci-robot · 2025-11-25T15:57:42Z

openshift-ci-robot · 2025-12-03T13:25:17Z

jpinsonneau · 2025-12-04T13:36:15Z

config/samples/flows_v1alpha1_flowcollectorslice.yaml

+apiVersion: flows.netobserv.io/v1alpha1
+kind: FlowCollectorSlice
+metadata:
+  name: flowcollectorslice-sample
+spec:
+  sampling: 10


Can you please add an example with subnets here ? (commented out by default)

jpinsonneau · 2025-12-04T13:44:18Z

api/flowcollectorslice/v1alpha1/flowcollectorslice_types.go

+type FlowCollectorSliceStatus struct {
+	// `conditions` represent the latest available observations of an object's state
+	Conditions []metav1.Condition `json:"conditions"`
+}


It would be interesting to fill the status here.

I'm not sure about reporting overall netobserv components readiness, even if that would be useful for project admins not having access to cluster FlowCollector.

However, at least an overall readiness status and error messages would be good to have.

I've added some error here, related to the slice config, in particular related to the subnets and if there is overlaps with the admin config or with previously processed slices

github-actions · 2025-12-05T08:25:11Z

New images:

quay.io/netobserv/network-observability-operator:169a4a6
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-169a4a6
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-169a4a6

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:169a4a6 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-169a4a6

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-169a4a6
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

codecov · 2025-12-05T09:32:24Z

Codecov Report

❌ Patch coverage is 50.90909% with 135 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.61%. Comparing base (bdc695f) to head (b023a5f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...owcollectorslice/v1alpha1/zz_generated.deepcopy.go	15.06%	60 Missing and 2 partials ⚠️
...ler/flp/slicesstatus/flowcollectorslices_status.go	40.90%	38 Missing and 1 partial ⚠️
api/flowcollector/v1beta2/zz_generated.deepcopy.go	0.00%	15 Missing and 1 partial ⚠️
internal/controller/flp/flp_controller.go	10.00%	7 Missing and 2 partials ⚠️
internal/controller/flp/slices.go	92.20%	3 Missing and 3 partials ⚠️
internal/controller/flp/flp_pipeline_builder.go	85.71%	1 Missing and 1 partial ⚠️
main.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2171      +/-   ##
==========================================
- Coverage   73.29%   72.61%   -0.68%     
==========================================
  Files          82       86       +4     
  Lines        9339     9604     +265     
==========================================
+ Hits         6845     6974     +129     
- Misses       2072     2198     +126     
- Partials      422      432      +10

Flag	Coverage Δ
unittests	`72.61% <50.90%> (-0.68%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
api/flowcollector/v1beta2/flowcollector_types.go	`100.00% <ø> (ø)`
api/flowcollector/v1beta2/helper.go	`83.60% <100.00%> (+0.27%)`	⬆️
...ollectorslice/v1alpha1/flowcollectorslice_types.go	`100.00% <100.00%> (ø)`
internal/controller/flp/flp_monolith_objects.go	`59.74% <100.00%> (+0.51%)`	⬆️
internal/controller/flp/flp_monolith_reconciler.go	`53.79% <100.00%> (ø)`
internal/controller/flp/flp_transfo_objects.go	`90.47% <100.00%> (+0.15%)`	⬆️
internal/controller/flp/flp_transfo_reconciler.go	`63.49% <100.00%> (ø)`
internal/pkg/manager/manager.go	`66.66% <ø> (ø)`
internal/pkg/test/envtest.go	`96.89% <100.00%> (+0.03%)`	⬆️
main.go	`0.00% <0.00%> (ø)`
... and 6 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

openshift-ci · 2025-12-05T11:17:58Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mffiedler for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- slicesToFilters: generate FLP filters based on slices - slicesToFCSubnetLabels: extract slice subnetLabels from all slices, sorted alphabetically, and insert that between admin-defined labels and openshift-detected labels

- Create a status on FlowCollectorSlice CRD that includes: - Number of configured subnets - Filter being applied - Ready condition - SubnetOverlap condition - Add commented-out subnet config in FlowCollectorSlice sample - Add new admin config in FlowCollector sample

github-actions · 2025-12-05T15:21:13Z

New images:

quay.io/netobserv/network-observability-operator:4645e59
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-4645e59
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-4645e59

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:4645e59 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-4645e59

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-4645e59
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

openshift-merge-robot · 2025-12-05T16:32:24Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference label Nov 21, 2025

jotak force-pushed the per-tenant branch 2 times, most recently from 21fb6a3 to 71626ae Compare November 21, 2025 15:50

jotak added the needs-review Tells that the PR needs a review label Nov 21, 2025

jotak force-pushed the per-tenant branch from c76d887 to f9f80c3 Compare November 25, 2025 15:55

jotak requested review from OlivierCazade, jpinsonneau, leandroberetta and luisjira December 3, 2025 13:25

jpinsonneau reviewed Dec 4, 2025

View reviewed changes

jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 5, 2025

openshift-merge-robot added the needs-rebase label Dec 5, 2025

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 5, 2025

jotak force-pushed the per-tenant branch from 36d5c97 to c652bd9 Compare December 5, 2025 14:06

jotak added 5 commits December 5, 2025 15:06

NETOBSERV-2418: new FlowCollectorSlice API

65300f1

Implement FlowCollectorSlice

d9dd9d5

- slicesToFilters: generate FLP filters based on slices - slicesToFCSubnetLabels: extract slice subnetLabels from all slices, sorted alphabetically, and insert that between admin-defined labels and openshift-detected labels

Add test, fix duplicated namespaces filters

ab72b3d

fix test

aeb6402

jotak force-pushed the per-tenant branch from c652bd9 to 24cc237 Compare December 5, 2025 14:07

openshift-merge-robot removed the needs-rebase label Dec 5, 2025

jotak requested a review from jpinsonneau December 5, 2025 14:07

jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 5, 2025

Include higher priority slices in overlap warning reports

b023a5f

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 5, 2025

netobserv deleted a comment from github-actions bot Dec 5, 2025

jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 5, 2025

openshift-merge-robot added the needs-rebase label Dec 5, 2025

NETOBSERV-2418: new FlowCollectorSlice API #2171

Are you sure you want to change the base?

NETOBSERV-2418: new FlowCollectorSlice API #2171

Uh oh!

Conversation

jotak commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

openshift-ci-robot commented Nov 21, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

openshift-ci-robot commented Nov 21, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

openshift-ci-robot commented Nov 21, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

openshift-ci-robot commented Nov 25, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

openshift-ci-robot commented Dec 3, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

jpinsonneau Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

jotak Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

jpinsonneau Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

jotak Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 5, 2025

Uh oh!

codecov bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

openshift-ci bot commented Dec 5, 2025

Uh oh!

github-actions bot commented Dec 5, 2025

Uh oh!

openshift-merge-robot commented Dec 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jotak commented Nov 21, 2025 •

edited

Loading

openshift-ci-robot commented Nov 21, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 21, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 21, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 25, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 3, 2025 •

edited by openshift-ci bot

Loading

jotak Dec 5, 2025 •

edited

Loading

codecov bot commented Dec 5, 2025 •

edited

Loading