Skip to content

NETOBSERV-2485: DNS optimization, avoid searching for various suffixes #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jotak wants to merge 3 commits into
base: main
Choose a base branch
from
Open

NETOBSERV-2485: DNS optimization, avoid searching for various suffixes #2227

jotak wants to merge 3 commits into from

Conversation

@jotak
Copy link
Member

@jotak jotak commented Dec 3, 2025

Description

  • Optimize DNS lookups

Use Health/Alerts to help detect DNS optimizations

  • New Alert template dedicated to NX DOMAIN (with lesser severity)
  • Fix issues with the link to Network traffic page for DNS (dest-based,
    no bnf)
  • Add custom link for DNS optimization

Dependencies

Console: netobserv/network-observability-console-plugin#1117

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

jotak added 2 commits December 3, 2025 15:15
@jotak
NETOBSERV-2485: DNS optimization, avoid searching for various suffixes
cfd8b17
@jotak
Use Health/Alerts to help detect DNS optimizations
1b8fdce 
- New Alert template dedicated to NX DOMAIN (with lesser severity)
- Fix issues with the link to Network traffic page for DNS (dest-based,
  no bnf)
- Add custom link for DNS optimization
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 3, 2025 •
edited by openshift-ci bot
Loading

@jotak: This pull request references NETOBSERV-2485 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

Description

  • Optimize DNS lookups

Use Health/Alerts to help detect DNS optimizations

  • New Alert template dedicated to NX DOMAIN (with lesser severity)
  • Fix issues with the link to Network traffic page for DNS (dest-based,
    no bnf)
  • Add custom link for DNS optimization

Dependencies

Console: netobserv/network-observability-console-plugin#1117

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jpinsonneau for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak mentioned this pull request Dec 3, 2025
Open
10 tasks
@jotak jotak added the needs-review Tells that the PR needs a review label Dec 3, 2025
@codecov
Copy link

codecov bot commented Dec 3, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.31%. Comparing base (8b929d7) to head (9af114d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2227      +/-   ##
==========================================
+ Coverage   73.24%   73.31%   +0.07%     
==========================================
  Files          82       82              
  Lines        9339     9371      +32     
==========================================
+ Hits         6840     6870      +30     
  Misses       2075     2075              
- Partials      424      426       +2
Flag Coverage Δ
unittests 73.31% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...flowcollector/v1beta2/flowcollector_alert_types.go 97.46% <100.00%> (ø)
api/flowcollector/v1beta2/flowcollector_types.go 100.00% <ø> (ø)
...lector/v1beta2/flowcollector_validation_webhook.go 75.17% <100.00%> (ø)
.../controller/consoleplugin/consoleplugin_objects.go 86.86% <100.00%> (ø)
internal/controller/ebpf/agent_controller.go 59.34% <100.00%> (ø)
internal/pkg/helper/loki_config.go 100.00% <100.00%> (ø)
internal/pkg/metrics/alerts/alerts.go 95.40% <100.00%> (+0.84%) ⬆️
internal/pkg/metrics/alerts/builder.go 91.19% <100.00%> (-4.26%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci openshift-ci bot added the lgtm label Dec 4, 2025
@jotak jotak removed the needs-review Tells that the PR needs a review label Dec 4, 2025
stleerh
stleerh reviewed Dec 5, 2025
View reviewed changes
README.md
mode: Monolithic
monolithic:
url: 'http://my-netobserv-loki.netobserv.svc:3100/'
url: 'http://my-netobserv-loki.netobserv.svc.cluster.local.:3100/'
Copy link
Contributor

@stleerh stleerh Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra "." before ":3100".

README.md
querier:
manual:
url: http://my-netobserv-prometheus-server.netobserv.svc/
url: http://my-netobserv-prometheus-server.netobserv.svc.cluster.local./
Copy link
Contributor

@stleerh stleerh Dec 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra "." before ":3100".

RELEASE.md
querier:
manual:
url: http://my-netobserv-prometheus-server.netobserv.svc/
url: http://my-netobserv-prometheus-server.netobserv.svc.cluster.local./
Copy link
Contributor

@stleerh stleerh Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same extra "."

bundle/manifests/netobserv-operator.clusterserviceversion.yaml
"enable": false
},
"url": "http://loki.netobserv.svc:3100/"
"url": "http://loki.netobserv.svc.cluster.local.:3100/"
Copy link
Contributor

@stleerh stleerh Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra "." before ":3100". This one is critical, since this is a YAML file unlike before which were just documents.

It seems this issue is in many other places so correct them all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stleerh stleerh stleerh left review comments

@jpinsonneau jpinsonneau jpinsonneau approved these changes

@leandroberetta leandroberetta Awaiting requested review from leandroberetta

Assignees

@jpinsonneau jpinsonneau

Labels

jira/valid-reference lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jotak @openshift-ci-robot @stleerh @jpinsonneau