Removed edit_form.php out of date 'definition' function and replaced wit... #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with 'definition_after_data' to prevent warning message in Moodle 2.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...h 'definition_after_data' to prevent warning message in Moodle 2.2
I noticed a warning message when using the block in Moodle 2.2 (related to a missing 'bui_editingatfrontpage' element in edit_form.php). On further investigation I found that the 'definition' function had been overridden by an old Moodle 2.0 version, in order to remove one option from the drop-down 'bui_contexts' select element.
I've removed this override and replaced it with a 'definition_after_data' function that removes that single option from the 'bui_contexts' element before the form is displayed.
I've cherry-picked the change to both the _DEV and _STABLE branches (let me know if you want me to submit a separate pull request for the _STABLE branch).