Ensure QuicStreamChannel.shutdownOutput() is only called once all pre… #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vious writes were processed. Motivation: We need to ensure QuicStreamChannel.shutdownOutput() is only called once all previous writes were processed. This is necessary as otherwise shutdownOutput() might be called while some writes are still queued (due flowcontrol). Modifications: - Always do the shutdownOutput() via a ChannelFutureListener - Adjust tests Result: Always drain write queue first before shutdown the output.
normanmaurer
force-pushed
the
shutdown_fix
branch
from
2b1dbb9 to
c2fdcf7
Compare
|
/cc @yawkat ... |
yawkat
approved these changes
Jan 16, 2024
src/main/java/io/netty/incubator/codec/http3/Http3FrameToHttpObjectCodec.java
Outdated
Show resolved
Hide resolved
I agree... Once this is fixed I will see if I can simplify it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vious writes were processed.
Motivation:
We need to ensure QuicStreamChannel.shutdownOutput() is only called once all previous writes were processed. This is necessary as otherwise shutdownOutput() might be called while some writes are still queued (due flowcontrol).
Modifications:
Result:
Always drain write queue first before shutdown the output.