Improve temporary file creation logic

neuml · Mar 3, 2023 · d758e1f · d758e1f
1 parent ee0cc5a
commit d758e1f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/src/python/txtai/cloud/hub.py b/src/python/txtai/cloud/hub.py
@@ -88,10 +88,14 @@ def lfstrack(self):
             content += "embeddings filter=lfs diff=lfs merge=lfs -text\n"
 
             # pylint: disable=R1732
-            tmp = tempfile.NamedTemporaryFile()
-            with open(tmp.name, "w", encoding="utf-8") as f:
-                f.write(content)
+            with tempfile.NamedTemporaryFile(mode="w", delete=False) as tmp:
+                tmp.write(content)
+                attributes = tmp.name
 
+            # Upload file
             huggingface_hub.upload_file(
-                repo_id=self.config["container"], token=self.config.get("token"), path_or_fileobj=tmp.name, path_in_repo=os.path.basename(path)
+                repo_id=self.config["container"], token=self.config.get("token"), path_or_fileobj=attributes, path_in_repo=os.path.basename(path)
             )
+
+            # Remove temporary file
+            os.remove(attributes)
diff --git a/test/python/testcloud.py b/test/python/testcloud.py
@@ -125,10 +125,9 @@ def filedownload(**kwargs):
 
         # Initialize attributes file
         # pylint: disable=R1732
-        tmp = tempfile.NamedTemporaryFile()
-        with open(tmp.name, "w", encoding="utf-8") as f:
-            f.write("*.bin filter=lfs diff=lfs merge=lfs -text\n")
-        attributes = tmp.name
+        with tempfile.NamedTemporaryFile(mode="w", delete=False) as tmp:
+            tmp.write("*.bin filter=lfs diff=lfs merge=lfs -text\n")
+            attributes = tmp.name
 
         # Run tests with uncompressed and compressed index
         for path in [f"cloud.{provider}", f"cloud.{provider}.tar.gz"]: