Fix dark mode after textual update #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niksirbi
approved these changes
Dec 5, 2024
Co-authored-by: Niko Sirmpilatze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Textual recently had a breaking change where they added a lot of new themes (looks pretty cool here, could expose some!)
The
app.darkattribute is now unused and.themeis used instead. This PR now sets.themeto the appropriate values to reproduce the old behaviour.Tests are failing due to #446, which will be merged soon. Changes in this PR are only minimal on the main code (around setting light / dark mode).