Fix Out of Bounds error during testing. #447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often in testing we were getting errors like:
This is due to the screen not being large enough, as discussed here. They provided the very useful information that there is a function
app.save_screenshot()
that allows you to see the state of the screen at the test time.It turned out at the issue (in this case) was that when clicking onto the project selector screen, it was completely blank. This led the terminal size of shrink and nothing was clicked on when the app tried to click on the project name.
The issue was that I forgot to add
pilot.pause()
after the call to click on the project selector screenso the test was moving directly onto the next step (clicking the project button) before the screen had loaded.
[EDIT]
Also, this fixed a case I found where forgot to add assert to a check. It was just easier to include on this PR.