Fix for issue #466 #471
Open
Fix for issue #466 #471
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @parharti and @JoeZiminski . Sorry, had to revamp through a new fork . But here I have split commits for both issues in separate PR's |
|
I have your comments from the previous PR, I'll be going through them and continue with the refactoring and all. Thanks for the feedback. |
|
Hi @aakash-test7 thanks a lot for this, much appreciated. I will review once #464 is merged, because I think this PR can leverage some of the new changes. Cheers! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhacement for issue #466 . Create a new function to check for datatype mismatch between narrow and broad datatypes.