Move rlcone error. #500
Closed
Move rlcone error. #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT:
on further consideration this is quite complex, as rclone configs are setup up-front. So this would only work in local-only mode, and it is fiddly. As rlcone config is not too onerous it just means the package is not pip-installable, and users that do not transfer are unecessarily downloading a package. It's not ideal but will leave this for now, because changing this is quite deep in the codebase and will require a lot of thinking / checking.
The implementation here is not good, it would be necessary to make a new decorator @requires_rclone.
There is a check that
rcloneis installed, which raises if it is not installed. Previously this was in theDataShuttleclass__init__, however now people will want to use datashuttle for validation / creating folders in local mode and will not need transfer. Therefore, this PR moves the check to the configs-check decorator used before transfer.The install documentation can be changed, and this will be done on #499 to avoid merge conflicts. No tests are requred.