Add password for SSH, AWS and GDrive config #600

JoeZiminski · 2025-09-11T20:00:07Z

Branched from refactor_ssh_connection

This PR adds the ability to encrypt the Rclone config files.

TODO:

add all docstrings and check type hints
Tests
documentation

datashuttle/datashuttle_class.py

datashuttle/utils/rclone.py

datashuttle/tui/screens/setup_gdrive.py

datashuttle/utils/rclone.py

Co-authored-by: Copilot <[email protected]>

Copilot · 2025-11-20T15:24:10Z

@JoeZiminski I've opened a new pull request, #637, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <[email protected]>

* Initial plan * Fix typo: 'ecrypted' → 'encrypted' in test docstring Co-authored-by: JoeZiminski <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JoeZiminski <[email protected]>

Co-authored-by: Copilot <[email protected]>

….com:neuroinformatics-unit/datashuttle into add_password_to_rclone_config_for_aws_gdrive

Copilot

Pull Request Overview

Copilot reviewed 45 out of 45 changed files in this pull request and generated 14 comments.

Comments suppressed due to low confidence (1)

datashuttle/tui/screens/setup_ssh.py:219

Except block directly handles BaseException.

        except BaseException:

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

datashuttle/tui/screens/setup_aws.py

docs/source/pages/get_started/set-up-a-project.md

datashuttle/utils/rclone_encryption.py

datashuttle/tui/screens/setup_ssh.py

datashuttle/datashuttle_class.py

datashuttle/utils/rclone_encryption.py

datashuttle/configs/canonical_folders.py

datashuttle/datashuttle_class.py

Co-authored-by: Copilot <[email protected]>

….com:neuroinformatics-unit/datashuttle into add_password_to_rclone_config_for_aws_gdrive

JoeZiminski changed the title ~~Refactor SSH connection to make adding passwords easier.~~ Add password for SSH, AWS and GDrive config Sep 12, 2025

github-advanced-security bot found potential problems Sep 24, 2025

View reviewed changes

datashuttle/datashuttle_class.py Fixed Show fixed Hide fixed

JoeZiminski marked this pull request as draft September 29, 2025 16:15

github-advanced-security bot found potential problems Sep 30, 2025

View reviewed changes

datashuttle/datashuttle_class.py Fixed Show fixed Hide fixed

JoeZiminski force-pushed the add_password_to_rclone_config_for_aws_gdrive branch from 53a5a05 to 274fe29 Compare October 2, 2025 18:08

JoeZiminski mentioned this pull request Oct 7, 2025

Refactor Configs #615

Open

github-advanced-security bot found potential problems Oct 7, 2025

View reviewed changes

datashuttle/utils/rclone.py Fixed Show fixed Hide fixed

JoeZiminski commented Oct 7, 2025

View reviewed changes

datashuttle/tui/screens/setup_gdrive.py Outdated Show resolved Hide resolved

JoeZiminski commented Oct 7, 2025

View reviewed changes

datashuttle/utils/rclone.py Outdated Show resolved Hide resolved

JoeZiminski changed the base branch from main to refactor_ssh_connection October 7, 2025 21:46

JoeZiminski force-pushed the add_password_to_rclone_config_for_aws_gdrive branch 3 times, most recently from 44af5de to 5c21724 Compare November 1, 2025 01:25

Base automatically changed from refactor_ssh_connection to main November 3, 2025 15:30

JoeZiminski force-pushed the add_password_to_rclone_config_for_aws_gdrive branch from 350ac89 to 0c2c1b2 Compare November 3, 2025 15:43

JoeZiminski marked this pull request as ready for review November 3, 2025 21:39

JoeZiminski and others added 14 commits November 3, 2025 23:38

Add separate config files for all connection methods.

bb212ae

Add password machinery for windows.

f02d6f1

Prototype input for set up ssh connection.

bcc5da4

Refactor rclone call functions to handle password.

0c4017e

Adding to google drive.

9581d5a

Added password to google dirve.

ba27591

Working on aws.

18158b9

Done adding to Linux.

0bbfeca

Add to macOS.

5329c58

Set different names for different projects.

4372550

Refactoring.

366d67b

Refactoring more.

ebf073a

Tidy up rclone_password.py

53dcc5c

Editing setup_ssh.

22a8db0

JoeZiminski and others added 2 commits November 20, 2025 15:20

Update datashuttle/utils/rclone.py

94614fc

Co-authored-by: Copilot <[email protected]>

Improve a test docstring.

cec3c50

Copilot AI mentioned this pull request Nov 20, 2025

Fix typo in test docstring: 'ecrypted' → 'encrypted' #637

Merged

JoeZiminski and others added 9 commits November 20, 2025 15:25

Remove debugging clause.

1991857

Update datashuttle/configs/rclone_configs.py

0f50c1b

Co-authored-by: Copilot <[email protected]>

Update datashuttle/configs/rclone_configs.py

ed1a89d

Co-authored-by: Copilot <[email protected]>

Update datashuttle/utils/rclone_encryption.py

f5f44da

Co-authored-by: Copilot <[email protected]>

Fix broken try / except.

b1a5032

Merge branch 'add_password_to_rclone_config_for_aws_gdrive' of github…

ebcd89d

….com:neuroinformatics-unit/datashuttle into add_password_to_rclone_config_for_aws_gdrive

Replace direct raise with utils function.

06b4a93

Fixes to rclone_encryption.py

6fdb357

JoeZiminski requested a review from Copilot November 20, 2025 15:51

Copilot started reviewing on behalf of JoeZiminski November 20, 2025 15:52 View session

Copilot finished reviewing on behalf of JoeZiminski November 20, 2025 15:55

Copilot AI reviewed Nov 20, 2025

View reviewed changes

JoeZiminski and others added 13 commits November 20, 2025 16:14

Small fixes rclone encryption.

e873b76

Update datashuttle/datashuttle_class.py

3d2cd66

Co-authored-by: Copilot <[email protected]>

Update datashuttle/configs/canonical_folders.py

531eb02

Co-authored-by: Copilot <[email protected]>

Update datashuttle/datashuttle_class.py

8f14c9e

Co-authored-by: Copilot <[email protected]>

Update datashuttle/configs/rclone_configs.py

07bef3d

Co-authored-by: Copilot <[email protected]>

Fix broken datashuttle version check.

e49b526

Update datashuttle/utils/rclone_encryption.py

4d5450e

Co-authored-by: Copilot <[email protected]>

Update docs/source/pages/get_started/set-up-a-project.md

34981f5

Co-authored-by: Copilot <[email protected]>

Update datashuttle/tui/screens/setup_aws.py

33ce2d7

Co-authored-by: Copilot <[email protected]>

Update datashuttle/tui/screens/setup_aws.py

bf84a44

Co-authored-by: Copilot <[email protected]>

Merge branch 'add_password_to_rclone_config_for_aws_gdrive' of github…

651c7dd

….com:neuroinformatics-unit/datashuttle into add_password_to_rclone_config_for_aws_gdrive

Small fixes to sucess message.

07a3c0e

Tidy up docs.

f42d7b2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add password for SSH, AWS and GDrive config #600

Add password for SSH, AWS and GDrive config #600

Uh oh!

JoeZiminski commented Sep 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Nov 20, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add password for SSH, AWS and GDrive config #600

Are you sure you want to change the base?

Add password for SSH, AWS and GDrive config #600

Uh oh!

Conversation

JoeZiminski commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Nov 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JoeZiminski commented Sep 11, 2025 •

edited

Loading