-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate VIA and COCO files for untracked data #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfmig
changed the title
Read manual labels from VIA or COCO as dataframe
Validate VIA and COCO files for untracked data
Dec 16, 2024
10 tasks
sfmig
force-pushed
the
smg/read-via-annotations
branch
2 times, most recently
from
December 16, 2024 18:43
5dcbf0d
to
17711ff
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
sfmig
force-pushed
the
smg/read-via-annotations
branch
from
December 16, 2024 19:05
db737ba
to
1e1c9cc
Compare
…r VIA_JSON_1_sample only
…sing_keys. Add test_valid_via_coco_json_with_schema_error (not passing)
…t for expected file errors in VIA & COCO validators.
…esponding test for COCO files.
…alProperties fix)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
What does this PR do?
Adds an
annotations
module for creating and manipulating annotations objects. This PR focuses on defining validators for input data files with bounding boxes annotations.More specifically:
Questions
Right now in the generic JSON validation I follow the jsonschema package, which only checks the types of keys if they are defined in the schema. That means that if none of the keys in the schema appear in the file, the validation still passes (see example below). The reason for this is simplicity. I only check if specific keys are present in the VIA and COCO files validation. Any thoughts on this? Right now I am thinking I can make it more strict later if it becomes a problem.
E.g. the following validation passes:
I define the file-specific validators as subclasses of the JSON validator, but also make the validations in these subclasses more strict. Is this a good idea? According to this SO post this is bad practice. I think it is alright, but curious to hear other thoughts.
TODO:
References
Please reference any existing issues/PRs that relate to this PR.
How has this PR been tested?
Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.
Is this a breaking change?
If this PR breaks any existing functionality, please explain how and why.
Does this PR require an update to the documentation?
If any features have changed, or have been added. Please explain how the
documentation has been updated.
Checklist: